Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add new action 'GlobalLine' #88

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

metepg
Copy link
Contributor

@metepg metepg commented Dec 9, 2024

  • New action 'GlobalLine' works just like 'Line' but allows jumps across visible editors.
  • Made small refactoring to Actions class to make other global actions easier to implement.

- Created class JumpMode since enums are not available without Kotlin standard library. This allows both jump handlers to use the same values.
- Added variable 'handler' as a parameter for BaseAction so its more descriptive which handler the action uses.
- This action is copy of the 'LineFinder' action but with the added possibility of jumping through all the visible editors.
@metepg
Copy link
Contributor Author

metepg commented Dec 9, 2024

It is possible to implement all the other actions to work globally too. I will create PR's from them when I have time but If you think it's a bad idea or not suitable for KJump its ok too :)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Please upload report for BASE (development@2ab2a52). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/main/kotlin/com/werfad/Actions.kt 0.00% 21 Missing ⚠️
src/main/kotlin/com/werfad/JumpMode.kt 0.00% 8 Missing ⚠️
src/main/kotlin/com/werfad/JumpHandler.kt 0.00% 6 Missing ⚠️
.../main/kotlin/com/werfad/finder/GlobalLineFinder.kt 0.00% 4 Missing ⚠️
src/main/kotlin/com/werfad/GlobalJumpHandler.kt 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             development     #88   +/-   ##
=============================================
  Coverage               ?   5.54%           
=============================================
  Files                  ?      20           
  Lines                  ?     469           
  Branches               ?      69           
=============================================
  Hits                   ?      26           
  Misses                 ?     443           
  Partials               ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants